| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Dec 2012 07:56:45 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To: "ludovic.desroches" <ludovic.desroches@...el.com>
Cc: Wenyou Yang <wenyou.yang@...el.com>,
linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
richard.genoud@...il.com, JM.Lin@...el.com,
nicolas.ferre@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [v2 PATCH 13/14] ARM: dts: add spi nodes for atmel SoC
On 17:37 Thu 06 Dec , ludovic.desroches wrote:
> Hi,
>
> On 12/04/2012 08:53 AM, Wenyou Yang wrote:
> >From: Richard Genoud <richard.genoud@...il.com>
> >
> >Signed-off-by: Richard Genoud <richard.genoud@...il.com>
> >[wenyou.yang@...el.com: add spi nodes for other atmel SOC]
> >Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> >Cc: linux@....linux.org.uk
> >---
> > arch/arm/boot/dts/at91sam9260.dtsi | 30 ++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/at91sam9263.dtsi | 30 ++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/at91sam9g45.dtsi | 30 ++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/at91sam9n12.dtsi | 30 ++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/at91sam9x5.dtsi | 30 ++++++++++++++++++++++++++++++
> > 5 files changed, 150 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >index d410581..87254aa 100644
> >--- a/arch/arm/boot/dts/at91sam9260.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >@@ -212,6 +212,36 @@
> > status = "disabled";
> > };
> >
> >+ spi0: spi@...c8000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9260-spi";
> >+ reg = <0xfffc8000 0x200>;
> >+ interrupts = <12 4 3>;
> >+ cs-gpios = <&pioA 3 0
> >+ &pioC 11 0
> >+ &pioC 16 0
> >+ &pioC 17 0
> >+ >;
>
> From my point of view, the cs-gpios stuff should be in board dts
> files instead of the SoC dtsi file.
>
> These pios can be shared with other devices. If only one chip select
> gpio is used on the board, it could avoid some useless pin
> conflicts.
agree and you MUST based on work on what I send on the ML and Grant applyed
Best Regards,
J.
>
> Regards
>
> Ludovic
>
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> >+
> >+ spi1: spi@...cc000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9260-spi";
> >+ reg = <0xfffcc000 0x200>;
> >+ interrupts = <13 4 3>;
> >+ cs-gpios = <&pioB 3 0
> >+ &pioC 5 0
> >+ &pioC 4 0
> >+ &pioC 3 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> >+
> > adc0: adc@...e0000 {
> > compatible = "atmel,at91sam9260-adc";
> > reg = <0xfffe0000 0x100>;
> >diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> >index 3e6e5c1..528395d 100644
> >--- a/arch/arm/boot/dts/at91sam9263.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9263.dtsi
> >@@ -195,6 +195,36 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> >+
> >+ spi0: spi@...a4000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9260-spi";
> >+ reg = <0xfffa4000 0x200>;
> >+ interrupts = <14 4 3>;
> >+ cs-gpios = <&pioA 5 0
> >+ &pioA 3 0
> >+ &pioA 4 0
> >+ &pioB 11 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> >+
> >+ spi1: spi@...a8000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9260-spi";
> >+ reg = <0xfffa8000 0x200>;
> >+ interrupts = <15 4 3>;
> >+ cs-gpios = <&pioB 15 0
> >+ &pioB 16 0
> >+ &pioB 17 0
> >+ &pioB 18 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> > };
> >
> > nand0: nand@...00000 {
> >diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> >index 3add030..8a6aae92 100644
> >--- a/arch/arm/boot/dts/at91sam9g45.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> >@@ -262,6 +262,36 @@
> > trigger-value = <0x6>;
> > };
> > };
> >+
> >+ spi0: spi@...a4000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9260-spi";
> >+ reg = <0xfffa4000 0x200>;
> >+ interrupts = <14 4 3>;
> >+ cs-gpios = <&pioB 3 0
> >+ &pioB 18 0
> >+ &pioB 19 0
> >+ &pioD 27 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> >+
> >+ spi1: spi@...a8000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9260-spi";
> >+ reg = <0xfffa8000 0x200>;
> >+ interrupts = <15 4 3>;
> >+ cs-gpios = <&pioB 17 0
> >+ &pioD 28 0
> >+ &pioD 18 0
> >+ &pioD 19 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> > };
> >
> > nand0: nand@...00000 {
> >diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi
> >index 82508d6..183cacf 100644
> >--- a/arch/arm/boot/dts/at91sam9n12.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9n12.dtsi
> >@@ -202,6 +202,36 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> >+
> >+ spi0: spi@...00000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9x5-spi";
> >+ reg = <0xf0000000 0x100>;
> >+ interrupts = <13 4 3>;
> >+ cs-gpios = <&pioA 14 0
> >+ &pioA 7 0
> >+ &pioA 1 0
> >+ &pioB 3 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> >+
> >+ spi1: spi@...04000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9x5-spi";
> >+ reg = <0xf0004000 0x100>;
> >+ interrupts = <14 4 3>;
> >+ cs-gpios = <&pioA 8 0
> >+ &pioA 0 0
> >+ &pioA 31 0
> >+ &pioA 30 0
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> > };
> >
> > nand0: nand@...00000 {
> >diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> >index 03fc136..95b55fd 100644
> >--- a/arch/arm/boot/dts/at91sam9x5.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> >@@ -263,6 +263,36 @@
> > trigger-value = <0x6>;
> > };
> > };
> >+
> >+ spi0: spi@...00000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9x5-spi";
> >+ reg = <0xf0000000 0x100>;
> >+ interrupts = <13 4 3>;
> >+ cs-gpios = <&pioA 14 0
> >+ &pioA 7 0 /* conflicts with TXD2 */
> >+ &pioA 1 0 /* conflicts with RXD0 */
> >+ &pioB 3 0 /* conflicts with ERXDV */
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> >+
> >+ spi1: spi@...04000 {
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "atmel,at91sam9x5-spi";
> >+ reg = <0xf0004000 0x100>;
> >+ interrupts = <14 4 3>;
> >+ cs-gpios = <&pioA 8 0 /* conflitcs with RXD2 */
> >+ &pioA 0 0 /* conflitcs with TXD0 */
> >+ &pioA 31 0 /* conflitcs with TWCK0 */
> >+ &pioA 30 0 /* conflitcs with TWD0 */
> >+ >;
> >+ dma-mask = <0xffffffff>;
> >+ status = "disabled";
> >+ };
> > };
> >
> > nand0: nand@...00000 {
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists