linux-kernel - Re: [PATCH] MCE: fix an error of mce_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121207074643.GA27523@liondog.tnic>
Date:	Fri, 7 Dec 2012 08:46:43 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Xishi Qiu <qiuxishi@...wei.com>
Cc:	WuJianguo <wujianguo@...wei.com>, Liujiang <jiang.liu@...wei.com>,
	andi@...stfloor.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] MCE: fix an error of mce_bad_pages statistics

On Fri, Dec 07, 2012 at 03:35:15PM +0800, Xishi Qiu wrote:
> Hi Borislav, you mean we should move this to the beginning of soft_offline_page()?
> 
> soft_offline_page()
> {
> 	...
> 	get_any_page()
> 	...
> 	/*
> 	 * Synchronized using the page lock with memory_failure()
> 	 */
> 	if (PageHWPoison(page)) {
> 		unlock_page(page);

Basically yes, except without the unlock_page. Where do you do lock_page
earlier so that you need to unlock it now?

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/