linux-kernel - Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYZcEpN-BJy=3DPAQL+QgR+EyNeyABtAPE96+2hYxOQwQ@mail.gmail.com>
Date:	Fri, 7 Dec 2012 09:09:47 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs

On Thu, Dec 6, 2012 at 11:52 AM, Peter Ujfalusi <peter.ujfalusi@...com> wrote:

> As Grant commneted on the first version:
> https://lkml.org/lkml/2012/12/5/53
>
> Introduce bitfields to cache the directionand output status of the pins so we
> can report them correctly.
> To do this I did some cleanup within the driver to get rid of the global
> variables and moved them under a private structure, changed the locking as well
> to protect the bitfield operation.
> As a last patch I added a note that the PWMA/B handling should not be in this
> driver at all.

This looks good to me:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Since Grant was requesting the changes I'll let him decide to merge.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/