linux-kernel - Re: [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wqwum5io.fsf@intel.com>
Date:	Fri, 07 Dec 2012 14:05:35 +0200
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Chris Wilson <chris@...is-wilson.co.uk>,
	Tim Gardner <tim.gardner@...onical.com>,
	linux-kernel@...r.kernel.org
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	Tim Gardner <tim.gardner@...onical.com>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

On Fri, 07 Dec 2012, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
>> 
>> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner@...onical.com> wrote:
>> > +	if (!saved_mode) {
>> > +		pr_err("i915: Could not allocate saved display mode.\n");
>> 
>> Please use DRM_ERROR().
>
> Truthfully neither, but join the growing petition to get real errorcodes
> back to userspace!

Heh, agreed, but in the mean time (i.e. before hell freezes over) I
think we should prefer DRM_ERROR over pr_err for consistency.

Jani.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/