linux-kernel - Re: Sharing PCIE driver between Microblaze and Arm zynq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121207131706.EC9273E0B87@localhost>
Date:	Fri, 07 Dec 2012 13:17:06 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Michal Simek <michal.simek@...inx.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-arm <linux-arm-kernel@...ts.infradead.org>,
	Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
	linux-arch@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Cc:	John Linn <John.Linn@...inx.com>,
	John Williams <jwilliams@...inx.com>
Subject: Re: Sharing PCIE driver between Microblaze and Arm zynq

On Thu, 6 Dec 2012 15:23:14 +0100, Michal Simek <michal.simek@...inx.com> wrote:
> Hi guys,
> 
> I have a question regarding to sharing generic OF pcie driver between
> two architectures MB and ARM Zynq.
> Is drivers/pci/pcie location good for it?
> Make no sense to have the same driver in two locations.
> Is using readl/writel IO functions in this driver the best option
> which we can have?
> Or is there any other recommendation?
> 
> Also just want to check if it is correct to use pcie device_type.
> The rest should be the same with pci description:
> (http://devicetree.org/MPC5200:PCI#PCI_Address_Translation).

Yes. device_type may be deprecated, but the PCI binding predates that.
PowerPC uses pcie in the device type. arch/powerpc/kernel/of_platform.c

Some of that powerpc DT PCI support code really should be made generic.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/