linux-kernel - Re: [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50C1F783.6090501@ti.com>
Date:	Fri, 7 Dec 2012 15:04:51 +0100
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>,
	<linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	Thierry Reding <thierry.reding@...onic-design.de>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings

On 12/07/2012 02:34 PM, Grant Likely wrote:
> It really needs to look like this:
> 
> pwmleds {
> 	compatible = "pwm-leds";
> 	kpad {
> 		label = "omap4::keypad";
> 		max-brightness = <127>;
> 		pwms = <&twl_pwm 0 7812500>;
> 	};
> 	charging {
> 		label = "omap4:green:chrg";
> 		max-brightness = <255>;
> 		pwms = <&twl_pwmled 0 7812500>;
> 	};
> };

OK.
So What we need to do is export the of_pwm_request() from drivers/pwm/core.c
Client drivers us of_pwm_request(node, NULL); to get the pwm when booted with DT.
Works fine on my setup this way and the DTS section looks just as you have
described.
Now I need to clean them up and resubmit.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/