| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1661490.lfKgYmIiUQ@vostro.rjw.lan>
Date: Mon, 10 Dec 2012 00:02:41 +0100
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
linux-pci@...r.kernel.org, Yinghai Lu <yinghai@...nel.org>,
Toshi Kani <toshi.kani@...com>,
Myron Stowe <myron.stowe@...hat.com>
Subject: [PATCH 4/6] ACPI: Reduce the usage of struct acpi_bus_ops
From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Objects of type struct acpi_bus_ops are currently used to pass
information between different parts of the ACPI namespace scanning
code, sometimes in quite convoluted ways. It turns out that that
is not necessary in some cases, so simplify the code by reducing
the utilization of struct acpi_bus_ops objects where clearly
possible.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
---
drivers/acpi/scan.c | 39 +++++++++++++++------------------------
1 file changed, 15 insertions(+), 24 deletions(-)
Index: linux/drivers/acpi/scan.c
===================================================================
--- linux.orig/drivers/acpi/scan.c
+++ linux/drivers/acpi/scan.c
@@ -1527,7 +1527,6 @@ end:
static void acpi_bus_add_power_resource(acpi_handle handle)
{
struct acpi_bus_ops ops = {
- .acpi_op_add = 1,
.acpi_op_start = 1,
.acpi_op_match = 1,
};
@@ -1581,7 +1580,6 @@ static int acpi_bus_type_and_status(acpi
static acpi_status acpi_bus_check_add(acpi_handle handle, u32 lvl,
void *context, void **return_value)
{
- struct acpi_bus_ops *ops = context;
struct acpi_device *device = NULL;
int type;
unsigned long long sta;
@@ -1609,11 +1607,13 @@ static acpi_status acpi_bus_check_add(ac
* so, we needn't add it again, but we may still have to start it.
*/
acpi_bus_get_device(handle, &device);
- if (ops->acpi_op_add && !device) {
- struct acpi_bus_ops add_ops = *ops;
+ if (!device) {
+ struct acpi_bus_ops ops = {
+ .acpi_op_start = !!context,
+ .acpi_op_match = 0,
+ };
- add_ops.acpi_op_match = 0;
- acpi_add_single_object(&device, handle, type, sta, &add_ops);
+ acpi_add_single_object(&device, handle, type, sta, &ops);
if (!device)
return AE_CTRL_DEPTH;
@@ -1647,21 +1647,21 @@ static acpi_status acpi_bus_match_device
return status;
}
-static int acpi_bus_scan(acpi_handle handle, struct acpi_bus_ops *ops,
+static int acpi_bus_scan(acpi_handle handle, bool start,
struct acpi_device **child)
{
void *device = NULL;
acpi_status status;
int ret = 0;
- status = acpi_bus_check_add(handle, 0, ops, &device);
+ status = acpi_bus_check_add(handle, 0, (void *)start, &device);
if (ACPI_FAILURE(status)) {
ret = -ENODEV;
goto out;
}
acpi_walk_namespace(ACPI_TYPE_ANY, handle, ACPI_UINT32_MAX,
- acpi_bus_check_add, NULL, ops, &device);
+ acpi_bus_check_add, NULL, (void *)start, &device);
if (device)
acpi_walk_namespace(ACPI_TYPE_ANY, handle, ACPI_UINT32_MAX,
acpi_bus_match_device, NULL, NULL, NULL);
@@ -1691,9 +1691,7 @@ int
acpi_bus_add(struct acpi_device **child,
struct acpi_device *parent, acpi_handle handle, int type)
{
- struct acpi_bus_ops ops = { .acpi_op_add = 1, };
-
- return acpi_bus_scan(handle, &ops, child);
+ return acpi_bus_scan(handle, false, child);
}
EXPORT_SYMBOL(acpi_bus_add);
@@ -1781,12 +1779,10 @@ static int acpi_bus_scan_fixed(void)
{
int result = 0;
struct acpi_device *device = NULL;
- struct acpi_bus_ops ops;
-
- memset(&ops, 0, sizeof(ops));
- ops.acpi_op_add = 1;
- ops.acpi_op_start = 1;
- ops.acpi_op_match = 1;
+ struct acpi_bus_ops ops = {
+ .acpi_op_start = 1,
+ .acpi_op_match = 1,
+ };
/*
* Enumerate all fixed-feature devices.
@@ -1812,11 +1808,6 @@ static int acpi_bus_scan_fixed(void)
int __init acpi_scan_init(void)
{
int result;
- struct acpi_bus_ops ops;
-
- memset(&ops, 0, sizeof(ops));
- ops.acpi_op_add = 1;
- ops.acpi_op_start = 1;
result = bus_register(&acpi_bus_type);
if (result) {
@@ -1830,7 +1821,7 @@ int __init acpi_scan_init(void)
/*
* Enumerate devices in the ACPI namespace.
*/
- result = acpi_bus_scan(ACPI_ROOT_OBJECT, &ops, &acpi_root);
+ result = acpi_bus_scan(ACPI_ROOT_OBJECT, true, &acpi_root);
if (!result)
result = acpi_bus_scan_fixed();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists