linux-kernel - Re: [PATCH] staging: echo: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121209151909.GC25293@gmail.com>
Date:	Sun, 9 Dec 2012 15:19:09 +0000
From:	Cong Ding <dinggnu@...il.com>
To:	Steve Underwood <steveu@...pice.org>,
	David Rowe <david@...etel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jesper Juhl <jj@...osbits.net>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: echo: remove unused variable

ping!

- cong

On Tue, Dec 04, 2012 at 01:21:44AM +0000, Cong Ding wrote:
> the variable j isn't used in the loop
> 
> Signed-off-by: Cong Ding <dinggnu@...il.com>
> ---
>  drivers/staging/echo/echo.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
> index ca87ce9..14dfd91 100644
> --- a/drivers/staging/echo/echo.c
> +++ b/drivers/staging/echo/echo.c
> @@ -119,7 +119,6 @@
>  static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
>  {
>  	int i;
> -	int j;
>  	int offset1;
>  	int offset2;
>  	int factor;
> @@ -142,7 +141,7 @@ static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
>  
>  	/* asm("st:"); */
>  	n = ec->taps;
> -	for (i = 0, j = offset2; i < n; i++, j++) {
> +	for (i = 0; i < n; i++) {
>  		exp = *phist++ * factor;
>  		ec->fir_taps16[1][i] += (int16_t) ((exp + (1 << 14)) >> 15);
>  	}
> -- 
> 1.7.4.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/