lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 10 Dec 2012 12:46:13 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Przemo Firszt <przemo@...szt.eu>
Cc:	Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	greg@...ah.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] rtl8712: replace leading spaces with tab

On Sun, Dec 09, 2012 at 10:15:10AM +0000, Przemo Firszt wrote:
> Replace leading spaces with tab
> 
> Signed-off-by: Przemo Firszt <przemo@...szt.eu>
> ---
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index b131b61..b4629c3 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -510,7 +510,7 @@ exit:
>  }
>  
>  static int r871x_set_wpa_ie(struct _adapter *padapter, char *pie,
> -			    unsigned short ielen)
> +				unsigned short ielen)

The original version is better because it lines up correctly.

Checkpatch doesn't complain for me so I'm not sure what the story is
here.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ