linux-kernel - Re: [PATCH v2 03/44] Add CONFIG_HAVE_64BIT_ALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50C5B7E3.2080909@imgtec.com>
Date:	Mon, 10 Dec 2012 10:22:27 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	<linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	Balbir Singh <bsingharora@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Eric Paris <eparis@...hat.com>, Will Drewry <wad@...omium.org>,
	James Morris <james.l.morris@...cle.com>
Subject: Re: [PATCH v2 03/44] Add CONFIG_HAVE_64BIT_ALIGNED_STRUCT for taskstats

On 08/12/12 03:43, H. Peter Anvin wrote:
> On 12/05/2012 08:08 AM, James Hogan wrote:
>> On 64 bit architectures with no efficient unaligned access, taskstats
>> has to add some padding to a reply to prevent unaligned access warnings.
>> However this also needs to apply to 32 bit architectures with 64 bit
>> struct alignment such as metag (which has 64 bit memory accesses).
> 
> Wait... 64-bit struct alignment on structures with only 32-bit members?
>  That might be... interesting... in a number of places...

Hi,

I'll rewrite the description as it's a bit misleading. On metag 64bit
struct alignment is required when it contains 64bit members, not if it
only contains 32bit members. Although metag is a 32bit arch, it can do
64bit memory accesses which must be aligned.

Thanks for taking a look.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/