linux-kernel - Re: [PATCH 5/5] rtl8712: replace leading spaces with tab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Dec 2012 15:21:03 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	devel@...verdev.osuosl.org, florian.c.schilhabel@...glemail.com,
	Przemo Firszt <przemo@...szt.eu>, linux-kernel@...r.kernel.org,
	Larry.Finger@...inger.net
Subject: Re: [PATCH 5/5] rtl8712: replace leading spaces with tab

On Mon, Dec 10, 2012 at 03:49:46AM -0800, Joe Perches wrote:
> On Mon, 2012-12-10 at 12:46 +0300, Dan Carpenter wrote:
> > On Sun, Dec 09, 2012 at 10:15:10AM +0000, Przemo Firszt wrote:
> > > Replace leading spaces with tab
> []
> > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> []
> > >  static int r871x_set_wpa_ie(struct _adapter *padapter, char *pie,
> > > -			    unsigned short ielen)
> > > +				unsigned short ielen)
> > 
> > The original version is better because it lines up correctly.
> > 
> > Checkpatch doesn't complain for me so I'm not sure what the story is
> > here.
> 
> Parenthesis alignment isn't described in CodingStyle.
> It's maintainer's preference.  Whether or not it should
> be is a different question.
> 
> checkpatch parenthesis alignment of arguments checks are
> emitted only when adding --strict to the command line.
> 

Even with --strict checkpatch.pl is fine with the original code.

I don't know any subsystems where the new version would be prefered
over the original version.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/