linux-kernel - Re: [PATCH 1/2] mtd: mxc_nand: fix unbalanced clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1355150764.2657.35.camel@sauron.fi.intel.com>
Date:	Mon, 10 Dec 2012 16:46:04 +0200
From:	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	linux-mtd@...ts.infradead.org,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-kernel@...r.kernel.org, Shawn Guo <shawn.guo@...aro.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 1/2] mtd: mxc_nand: fix unbalanced clk_disable() in
 error path

On Thu, 2012-12-06 at 08:42 +0100, Lothar Waßmann wrote:
> If nand_scan_ident() or nand_scan_tail() fails, the NAND chip may have
> been deselected and the clock already disabled. Thus, check 'clk_act'
> in the error path to decide whether the clock still needs to be
> disabled.
> 
> This fixes a:
> |WARNING: at drivers/clk/clk.c:472 __clk_disable+0x3c/0x78()

Pushed to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)