linux-kernel - Re: [PATCH v4 23/23] mfd: omap-usb-host: Don't spam console on clk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121210143806.GI11038@arwen.pp.htv.fi>
Date:	Mon, 10 Dec 2012 16:38:06 +0200
From:	Felipe Balbi <balbi@...com>
To:	Roger Quadros <rogerq@...com>
CC:	Rajendra Nayak <rnayak@...com>, <balbi@...com>,
	<sameo@...ux.intel.com>, <tony@...mide.com>, <paul@...an.com>,
	<sshtylyov@...sta.com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <keshava_mgowda@...com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <bjorn@...k.no>
Subject: Re: [PATCH v4 23/23] mfd: omap-usb-host: Don't spam console on
 clk_set_parent failure

On Mon, Dec 10, 2012 at 01:31:22PM +0200, Roger Quadros wrote:
> On 12/10/2012 01:24 PM, Rajendra Nayak wrote:
> > On Monday 10 December 2012 03:50 PM, Roger Quadros wrote:
> >> clk_set_parent is expected to fail on OMAP3 platforms. We don't
> >> consider that as fatal so don't spam console.
> > 
> > And what if it fails on a non-OMAP3 platform?
> 
> The driver just prints a debug message and continues to work just as
> before. The USB port will not work for the user in that case. He will
> have to enable DEBUG flag to see the debug message. I see this behaviour
> better than before where all OMAP3 users see the error message for no
> reason.

I agree with Roger here.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)