linux-kernel - Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50C65381.8010609@ahsoftware.de>
Date:	Mon, 10 Dec 2012 22:26:25 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	Lars-Peter Clausen <lars@...afoo.de>
CC:	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	Jonathan Cameron <jic23@....ac.uk>, rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	srinivas pandruvada <srinivas.pandruvada@...el.com>
Subject: Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
> On 12/10/2012 08:45 PM, Alexander Holler wrote:
>> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
>>
>>> Looks pretty good now. But there are still some IIO remnants which should be
>>> removed as well. Also the driver should move to drivers/rtc/ since, well,
>>> it's a rtc driver not a IIO driver.
>>
>> I think it still should be stick to iio, because that is where all HID
>> sensors currently are found and where the user would expect to find such
>> a driver.
> 
> That's because all the current IIO sensor drivers fall in the IIO domain. This
> one clearly is a RTC driver, so it belongs in drivers/rtc/

Where nobody will find it if he searches for drivers for his HID sensor.
I still see it as HID sensor driver and not a rtc-driver.
But ...

> 
>>
>>>> +/* Channel definitions */
>>>> +static const struct iio_chan_spec hid_time_channels[TIME_RTC_CHANNEL_MAX] = {
>>
>> And that is imho the last remaining iio-stuff. If necessary I can remove
>> it too.
> 
> That and the remaining bits of the read_raw callback.

Ok. I will make a v3.

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/