linux-kernel - Re: [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121210221045.4EA803E0D9C@localhost>
Date:	Mon, 10 Dec 2012 22:10:45 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Axel Lin <axel.lin@...ics.com>
Cc:	Kukjin Kim <kgene.kim@...sung.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Tomasz Figa <t.figa@...sung.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

On Mon, 10 Dec 2012 11:13:06 +0100, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Mon, Dec 10, 2012 at 2:35 AM, Axel Lin <axel.lin@...ics.com> wrote:
> 
> > The of_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > ---
> >  drivers/gpio/gpio-samsung.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> > index 01f7fe9..9e251be 100644
> > --- a/drivers/gpio/gpio-samsung.c
> > +++ b/drivers/gpio/gpio-samsung.c
> > @@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
> >         static const struct of_device_id exynos_pinctrl_ids[] = {
> >                 { .compatible = "samsung,pinctrl-exynos4210", },
> >                 { .compatible = "samsung,pinctrl-exynos4x12", },
> > +               { }
> 
> Wasn't somebody complaining that this was unnecessary recently?
> 
> Ohwell, I'll let the Samsung people comment first...

And this doesn't apply on my gpio/next branch. I assume it applies
somewhere else so I'll ignore for now. :-)

Acked-by: Grant Likely <grant.likely@...retlab.ca>

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/