| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121210060001.GE22164@linux.vnet.ibm.com> Date: Mon, 10 Dec 2012 11:30:01 +0530 From: Srikar Dronamraju <srikar@...ux.vnet.ibm.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>, Ananth N Mavinakayanahalli <ananth@...ibm.com>, Anton Arapov <anton@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/7] uprobes: Kill the "uprobe != NULL" check in uprobe_unregister() * Oleg Nesterov <oleg@...hat.com> [2012-11-23 21:28:02]: > Trivial. uprobe can't be NULL after mutex_unlock(), it was already used. > > Signed-off-by: Oleg Nesterov <oleg@...hat.com> Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com> > --- > kernel/events/uprobes.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index e9f22ed..13b247c 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -900,8 +900,7 @@ void uprobe_unregister(struct inode *inode, loff_t offset, struct uprobe_consume > } > > mutex_unlock(uprobes_hash(inode)); > - if (uprobe) > - put_uprobe(uprobe); > + put_uprobe(uprobe); > } > > static struct rb_node * > -- > 1.5.5.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists