linux-kernel - Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121211125713.GH9097@opensource.wolfsonmicro.com>
Date:	Tue, 11 Dec 2012 21:57:14 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Abhilash Kesavan <kesavan.abhilash@...il.com>
Cc:	linux-kernel@...r.kernel.org, lrg@...com,
	Olof Johansson <olof@...om.net>,
	Doug Anderson <dianders@...omium.org>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	devicetree-discuss@...ts.ozlabs.org, sameo@...ux.intel.com
Subject: Re: [RFC PATCH 2/3] regulator: max77686: Add support for various
 operating modes

On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote:
> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan
> <kesavan.abhilash@...il.com> wrote:

> > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes:

> >> Binding documenation is mandatory for any new OF properties, please add
> >> this.

> > Patch 3/3 of this series adds documentation for the max77686-opmode property.

There is no point in splitting changes like this up, it just makes
review harder - in this case it caused me to not read your patch due
to the missing documentation.  Put the whole change together unless
things are getting too big to review.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)