lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Dec 2012 16:26:47 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Arnd Bergmann <arnd@...db.de> Cc: linux-arm-kernel@...ts.infradead.org, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Andrew Lunn <andrew@...n.ch>, Yehuda Yitschak <yehuday@...vell.com>, Maen Suleiman <maen@...vell.com>, Jason Cooper <jason@...edaemon.net>, Tawfik Bayouk <tawfik@...vell.com>, Stephen Warren <swarren@...dotorg.org>, Thierry Reding <thierry.reding@...onic-design.de>, linux-kernel@...r.kernel.org, Jesse Barnes <jbarnes@...tuousgeek.org>, Eran Ben-Avi <benavi@...vell.com>, Nadav Haklai <nadavh@...vell.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Lior Amsalem <alior@...vell.com>, Shadi Ammouri <shadi@...vell.com>, Gregory Clement <gregory.clement@...e-electrons.com>, Yinghai Lu <yinghai@...nel.org> Subject: Re: [RFC v1 01/16] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT On Tue, Dec 11, 2012 at 10:43:49AM +0000, Arnd Bergmann wrote: > On Friday 07 December 2012, Thomas Petazzoni wrote: > > The pcim_*() functions are used by the libata-sff subsystem, and this > > subsystem is used for many SATA drivers on ARM platforms that do not > > necessarily have I/O ports. > > I think this one is wrong as the CONFIG_HAS_IOPORT does not refer to the > presence of PIO ports but to whether or not they provide an ioport_map > function. If there is no ioport_map(), devm_pci_iomap will fail to link > as far as I can tell. Correct. If HAS_IOPORT is not selected then we are potentially missing the dependent functions (because the platform has no IOPORT support) _or_ it does have ISA/PCI IO spaces _but_ they're not mappable via the ioport_map() mechanism due to some non-linearity involved in the translation. To make that second point clear, that's platforms where: ioport_map(addr + 4) != ioport_map(addr) + 4. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists