linux-kernel - Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Dec 2012 21:26:48 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Julia Lawall <julia.lawall@...6.fr>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree

Hello.

On 12/11/2012 04:08 PM, Julia Lawall wrote:

>>> From: Julia Lawall <Julia.Lawall@...6.fr>

>>> The function at91_dt_node_to_map is ultimately called by the function
>>> pinctrl_get, which is an exported function.  Since it is possible that this
>>> function is not called from within a probe function, for safety, the kfree
>>> is converted to a devm_kfree, to both free the data and remove it from the
>>> device in a failure situation.
>>
>>> A newline is added in the call to devm_kfree to avoid exceeding the 80
>>
>>    devm_kzalloc() you mean?

> Yes, sorry.  Should I send a new patch?

   Up to the maintainer I guess...

> thanks,
> julia

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/