linux-kernel - Re: [PATCH v2 04/10] net: smc911x: use io{read,write}*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121211.125156.1507794854679959729.davem@davemloft.net>
Date:	Tue, 11 Dec 2012 12:51:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	will.deacon@....com
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	benh@...nel.crashing.org, arnd@...db.de, james.hogan@...tec.com,
	matthew@...tleach.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 04/10] net: smc911x: use io{read,write}*_rep
 accessors

From: Will Deacon <will.deacon@....com>
Date: Tue, 11 Dec 2012 14:49:49 +0000

> On Mon, Dec 10, 2012 at 08:47:05PM +0000, David Miller wrote:
>> This misses the two uses in smsc911x_tx_writefifo and
>> smsc911x_rx_readfifo.
> 
> Well spotted, updated patch below.

Although I'd like to take credit, the compiler told me :-)

> From b46e33465e755e945136d19938c9a8331cbafce7 Mon Sep 17 00:00:00 2001
> From: Matthew Leach <matthew@...tleach.net>
> Date: Tue, 6 Nov 2012 14:51:11 +0000
> Subject: [PATCH v3] net: smc911x: use io{read,write}*_rep accessors
> 
> The {read,write}s{b,w,l} operations are not defined by all
> architectures and are being removed from the asm-generic/io.h
> interface.
> 
> This patch replaces the usage of these string functions in the smc911x
> accessors with io{read,write}{8,16,32}_rep calls instead.
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Ben Herrenschmidt <benh@...nel.crashing.org>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Matthew Leach <matthew@...tleach.net>
> Signed-off-by: Will Deacon <will.deacon@....com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/