linux-kernel - Re: [PATCH] drivers/pinctrl: grab default handles from device core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121211181336.GD25714@kroah.com>
Date:	Tue, 11 Dec 2012 10:13:36 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Felipe Balbi <balbi@...com>, Benoit Cousson <b-cousson@...com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Mitch Bradley <wmb@...mworks.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Kevin Hilman <khilman@...com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Rickard Andersson <rickard.andersson@...ricsson.com>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] drivers/pinctrl: grab default handles from device core

On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote:
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 86ef6ab..dc399ab 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -21,6 +21,7 @@
>  #include <linux/compiler.h>
>  #include <linux/types.h>
>  #include <linux/mutex.h>
> +#include <linux/pinctrl/devinfo.h>
>  #include <linux/pm.h>
>  #include <linux/atomic.h>
>  #include <linux/ratelimit.h>
> @@ -605,6 +606,8 @@ struct device_dma_parameters {
>   * @pm_domain:	Provide callbacks that are executed during system suspend,
>   * 		hibernation, system resume and during runtime PM transitions
>   * 		along with subsystem-level and driver-level callbacks.
> + * @pins:	For device pin management.
> + *		See Documentation/pinctrl.txt for details.
>   * @numa_node:	NUMA node this device is close to.
>   * @dma_mask:	Dma mask (if dma'ble device).
>   * @coherent_dma_mask: Like dma_mask, but for alloc_coherent mapping as not all
> @@ -656,6 +659,10 @@ struct device {
>  	struct dev_pm_info	power;
>  	struct dev_pm_domain	*pm_domain;
>  
> +#ifdef CONFIG_PINCTRL
> +	struct dev_pin_info	pins;
> +#endif

Can't you just make this a * to the structure, saving a bit of space for
those that don't use this structure?  Ok, it's only saving one pointer,
so it's really not a big deal to me if you don't want to do this, just
asking...

Also, this will have to wait until after 3.8-rc1 before I can consider
merging it, I'm a bit busy for the next two weeks at the least...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/