linux-kernel - Re: [PATCH 3/4] onkey: 88pm80x: update irq base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2012 14:26:26 +0800
From:	Qing Xu <qingx@...vell.com>
To:	Qing Xu <qingx@...vell.com>
Cc:	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	Qiao Zhou <zhouqiao@...vell.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	Chao Xie <cxie4@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] onkey: 88pm80x: update irq base

On 12/03/2012 01:42 PM, Qing Xu wrote:
> From: Qing Xu <qingx@...vell.com>
>
> irq base is stored in 88pm80x's drv data, we need to add irq
> base to get the correct irq num
>
> Signed-off-by: Qiao Zhou <zhouqiao@...vell.com>
> Signed-off-by: Qing Xu <qingx@...vell.com>
> ---
>   drivers/input/misc/88pm80x_onkey.c |    7 ++++---
>   1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/misc/88pm80x_onkey.c b/drivers/input/misc/88pm80x_onkey.c
> index 7f26e7b..cc352f9 100644
> --- a/drivers/input/misc/88pm80x_onkey.c
> +++ b/drivers/input/misc/88pm80x_onkey.c
> @@ -67,7 +67,7 @@ static int __devinit pm80x_onkey_probe(struct platform_device *pdev)
>   
>   	struct pm80x_chip *chip = dev_get_drvdata(pdev->dev.parent);
>   	struct pm80x_onkey_info *info;
> -	int err;
> +	int irq, err;
>   
>   	info = kzalloc(sizeof(struct pm80x_onkey_info), GFP_KERNEL);
>   	if (!info)
> @@ -75,13 +75,14 @@ static int __devinit pm80x_onkey_probe(struct platform_device *pdev)
>   
>   	info->pm80x = chip;
>   
> -	info->irq = platform_get_irq(pdev, 0);
> -	if (info->irq < 0) {
> +	irq = platform_get_irq(pdev, 0);
> +	if (irq < 0) {
>   		dev_err(&pdev->dev, "No IRQ resource!\n");
>   		err = -EINVAL;
>   		goto out;
>   	}
>   
> +	info->irq = irq + chip->irq_base;
>   	info->map = info->pm80x->regmap;
>   	if (!info->map) {
>   		dev_err(&pdev->dev, "no regmap!\n");


Samuel,

Could you help to review my patch? Thanks a lot!

Qing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/