linux-kernel - Re: [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2012 08:51:55 +0200
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	Cyril Roelandt <tipecaml@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <rui.zhang@...el.com>,
	<durgadoss.r@...el.com>, <rjw@...k.pl>,
	<devel@...verdev.osuosl.org>
Subject: Re: [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor()
 and in omap_thermal_register_cpu_cooling().

On 12-12-2012 02:24, Cyril Roelandt wrote:
>
> The omap_bandgap_get_sensor_data() function returns ERR_PTR(), so we need to use
> IS_ERR() rather than a NULL check.
>
> Signed-off-by: Cyril Roelandt <tipecaml@...il.com>

Acked-by: Eduardo Valentin <eduardo.valentin@...com>

> ---
>   drivers/staging/omap-thermal/omap-thermal-common.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/omap-thermal/omap-thermal-common.c b/drivers/staging/omap-thermal/omap-thermal-common.c
> index 61f1070..79a55aa 100644
> --- a/drivers/staging/omap-thermal/omap-thermal-common.c
> +++ b/drivers/staging/omap-thermal/omap-thermal-common.c
> @@ -260,7 +260,7 @@ int omap_thermal_expose_sensor(struct omap_bandgap *bg_ptr, int id,
>
>   	data = omap_bandgap_get_sensor_data(bg_ptr, id);
>
> -	if (!data)
> +	if (IS_ERR(data))
>   		data = omap_thermal_build_data(bg_ptr, id);
>
>   	if (!data)
> @@ -309,7 +309,7 @@ int omap_thermal_register_cpu_cooling(struct omap_bandgap *bg_ptr, int id)
>   	struct omap_thermal_data *data;
>
>   	data = omap_bandgap_get_sensor_data(bg_ptr, id);
> -	if (!data)
> +	if (IS_ERR(data))
>   		data = omap_thermal_build_data(bg_ptr, id);
>
>   	if (!data)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/