[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2012 16:05:05 +0100
From: Fubo Chen <fubo.chen@...il.com>
To: Namjae Jeon <linkinjeon@...il.com>
Cc: jaegeuk.kim@...sung.com, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-f2fs-devel@...ts.sourceforge.net,
Namjae Jeon <namjae.jeon@...sung.com>,
Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct
parent inode number
On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon <linkinjeon@...il.com> wrote:
> + /* dot and dotdot dentries should have zero-value hash code */
> + if (!memcmp(name, ".", 1) || !memcmp(name, "..", 2))
> + return 0;
That looks suspicious. If memcmp(name, "..", 2) == 0 then always
memcmp(name, ".", 1) == 0. Why two tests ?
Fubo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists