linux-kernel - Re: [PATCH] HID: i2c-hid: add mutex protecting open/close race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2012 17:54:21 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: add mutex protecting open/close race

On Wed, Dec 12, 2012 at 5:34 PM, Jean Delvare <khali@...ux-fr.org> wrote:
> Hi Benjamin,
>
> On Wed, 12 Dec 2012 17:12:16 +0100, Benjamin Tissoires wrote:
>> We should not enter close function while someone else is in open.
>> This mutex prevents this race.
>>
>> There is also no need to override the ret value with -EIO in case of
>> a failure of i2c_hid_set_power.
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...il.com>
>> ---
>
> Looks good to me except that you forgot to include <linux/mutex.h> and
> this could cause build failures on some architectures/configs.
>
> Once this is fixed, you can add:
>
> Reviewed-by: Jean Delvare <khali@...ux-fr.org>

Thanks, I will resend it right now.

Cheers,
Benjamin

>
> --
> Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/