[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2012 10:50:23 -0800
From: Julius Werner <jwerner@...omium.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: "Rafael J. Wysocki" <rjw@...k.pl>,
Francesco Lavra <francescolavra.fl@...il.com>,
linux-pm@...r.kernel.org,
Deepthi Dharwar <deepthi@...ux.vnet.ibm.com>,
Trinabh Gupta <g.trinabh@...il.com>,
Lists Linaro-dev <linaro-dev@...ts.linaro.org>,
len.brown@...el.com, linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Sameer Nanda <snanda@...omium.org>
Subject: Re: [PATCH] cpuidle - remove the power_specified field in the driver
Thanks again for making this happen, Daniel. I like this version,
except for the small nitpick that I still think it would make sense to
also turn the loop in menu.c around. How about something like this:
for (i = drv->state_count - 1; i >= CPUIDLE_DRIVER_STATE_START; i++) {
struct cpuidle_state *s = &drv->states[i];
if (!s->disable && s->exit_latency <= latency_req &&
s->target_residency <= data->predicted_us &&
s->exit_latency * multiplier <= data->predicted_us) {
data->last_state_idx = i;
data->exit_us = s->exit_latency;
break;
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists