linux-kernel - Re: [PATCH] drivers/pinctrl: grab default handles from device core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2012 20:58:54 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Felipe Balbi <balbi@...com>, Benoit Cousson <b-cousson@...com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Mitch Bradley <wmb@...mworks.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Kevin Hilman <khilman@...com>,
	Rickard Andersson <rickard.andersson@...ricsson.com>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] drivers/pinctrl: grab default handles from device core

On Wed, Dec 12, 2012 at 12:58 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@...osoft.com> wrote:

>> > +#ifdef CONFIG_PINCTRL
>> > +   struct dev_pin_info     pins;
>> > +#endif

> can do do not put ifdef in the struct as if will force us to put ifdef in the
> c code too instead of just use a inline function

Oh, I'm just planning to use this from the pinctrl core code itself
and the code in drivers/base/pinctrl.c (which is only compiled when
CONFIG_PINCTRL is set) so there is no risk for that right now.

I would agree if we exposed to drivers, like the dev_pm_ops...
but that's not the plan right now.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/