[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 13 Dec 2012 00:05:05 +0200
From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To: "H. Peter Anvin" <hpa@...ux.intel.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
David Rientjes <rientjes@...gle.com>,
Andrea Arcangeli <aarcange@...hat.com>, linux-mm@...ck.org,
Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org,
"Kirill A. Shutemov" <kirill@...temov.name>
Subject: Re: [PATCH v5 09/11] thp: lazy huge zero page allocation
On Wed, Dec 12, 2012 at 01:48:04PM -0800, H. Peter Anvin wrote:
> On 12/12/2012 01:30 PM, Andrew Morton wrote:
> >>
> >> I can rewrite the check to static_key if you want. Would it be better?
> >
> > The new test-n-branch only happens on the first read fault against a
> > thp huge page, yes? In which case it's a quite infrequent event and I
> > suspect this isn't worth bothering about.
> >
>
> Not to mention that flipping the static key is *incredibly* expensive.
I'm fine with current code.
--
Kirill A. Shutemov
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists