[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2012 05:23:16 +0100
From: Andi Kleen <andi@...stfloor.org>
To: Xishi Qiu <qiuxishi@...wei.com>
Cc: WuJianguo <wujianguo@...wei.com>, Liujiang <jiang.liu@...wei.com>,
Simon Jeons <simon.jeons@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Borislav Petkov <bp@...en8.de>,
Andi Kleen <andi@...stfloor.org>,
Fengguang Wu <fengguang.wu@...el.com>,
Wanpeng Li <liwanp@...ux.vnet.ibm.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 2/3] MCE: fix an error of mce_bad_pages statistics
> if (PageHWPoison(hpage)) {
> pr_info("soft offline: %#lx hugepage already poisoned\n", pfn);
> - return -EBUSY;
> + ret = -EBUSY;
> + goto out;
Doesn't look like a code improvement to me. Single return is easier and
simpler.
-Andi
> +out:
> return ret;
> }
> --
> 1.7.1
>
>
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists