linux-kernel - Re: [RFC/RFT][PATCH 1/4] regulator: core: Allow specify activate_[reg|bit] for regmap based voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121213084826.GG27624@opensource.wolfsonmicro.com>
Date:	Thu, 13 Dec 2012 08:48:26 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Haojian Zhuang <haojian.zhuang@...il.com>,
	David Dajun Chen <dchen@...semi.com>,
	Ashish Jangam <ashish.jangam@...tcummins.com>,
	Mike Rapoport <mike@...pulab.co.il>,
	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC/RFT][PATCH 1/4] regulator: core: Allow specify
	activate_[reg|bit] for regmap based voltage_sel operations

On Thu, Dec 13, 2012 at 04:44:08PM +0800, Axel Lin wrote:
> Some DVM regulators needs to update activate_bit after setting vsel_reg to
> initiate voltage change on the output.  This patch adds activate_reg and
> activate_bit to struct regulator_desc and update
> regulator_set_voltage_sel_regmap() to set activate_bit of activate_reg when
> activate_bit is set.

I'm not convinced about the naming here...  how about apply rather than
activate?  Not sure if it shouldn't be specific to voltage setting
either.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/