linux-kernel - Re: [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1212131222530.1966@hadrien>
Date:	Thu, 13 Dec 2012 12:23:39 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Dan Carpenter <dan.carpenter@...cle.com>
cc:	Evgeniy Polyakov <zbr@...emap.net>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm_ functions

On Thu, 13 Dec 2012, Dan Carpenter wrote:

> On Thu, Dec 13, 2012 at 11:18:53AM +0100, Julia Lawall wrote:
> > On Thu, 13 Dec 2012, Dan Carpenter wrote:
> >
> > > On Wed, Dec 12, 2012 at 01:25:56AM +0400, Evgeniy Polyakov wrote:
> > > > I suppose mdev will be automatically freed, but who will release
> > > > mdev->clk and other private members of mdev structure?
> > >
> > > +   mdev->clk = devm_clk_get(&pdev->dev, NULL);
> > >
> > > ->clk is now a devm pointer as well.
> >
> > Thanks for the suggestion.  I will submit a patch shortly.
> >
>
> Huh?  I think there is a miscommunication here.  I was trying to
> explain that your original patch handles releasing ->clk.
>
> I've reviewed the patch again and I still don't see a problem with
> it.  What will you change when you resubmit?

Oops, sorry.  I thought your +   mdev->clk = devm_clk_get(&pdev->dev,
NULL); was a suggestion of something I had overlooked.

Thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/