linux-kernel - Re: [PATCH 2/4] uprobes: Change filter_chain() to iterate ->consumers list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121213141246.GC3902@linux.vnet.ibm.com>
Date:	Thu, 13 Dec 2012 19:42:46 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <anton@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] uprobes: Change filter_chain() to iterate
 ->consumers list

* Oleg Nesterov <oleg@...hat.com> [2012-11-24 19:02:31]:

> Now that it safe to use ->consumer_rwsem under ->mmap_sem we can
> almost finish the implementation of filter_chain(). It still lacks
> the actual uc->filter(...) call but othewrwise it is ready, just
> it pretends that ->filter() always returns true.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>


Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

> ---
>  kernel/events/uprobes.c |   21 +++++++++++++--------
>  1 files changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index 03ffbb5..873c993 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -614,14 +614,19 @@ static int prepare_uprobe(struct uprobe *uprobe, struct file *file,
> 
>  static bool filter_chain(struct uprobe *uprobe)
>  {
> -	/*
> -	 * TODO:
> -	 *	for_each_consumer(uc)
> -	 *		if (uc->filter(...))
> -	 *			return true;
> -	 *	return false;
> -	 */
> -	return uprobe->consumers != NULL;
> +	struct uprobe_consumer *uc;
> +	bool ret = false;
> +
> +	down_read(&uprobe->consumer_rwsem);
> +	for (uc = uprobe->consumers; uc; uc = uc->next) {
> +		/* TODO: ret = uc->filter(...) */
> +		ret = true;
> +		if (ret)
> +			break;
> +	}
> +	up_read(&uprobe->consumer_rwsem);
> +
> +	return ret;
>  }
> 
>  static int
> -- 
> 1.5.5.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/