linux-kernel - Re: [PATCH] arch/tile: provide PT_FLAGS_COMPAT value in pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50CA0529.2050506@tilera.com>
Date:	Thu, 13 Dec 2012 11:41:13 -0500
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Oleg Nesterov <oleg@...hat.com>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/tile: provide PT_FLAGS_COMPAT value in pt_regs

On 12/13/2012 11:27 AM, Oleg Nesterov wrote:
> On 12/13, Chris Metcalf wrote:
>> On 12/13/2012 10:49 AM, Oleg Nesterov wrote:
>>> But ptrace_setoptions() returns EINVAL? it doesn't accept illegal bits.
>> It does return EINVAL - but if it gets both legal and illegal bits,
>> it honors all the legal bits first.
> This was true in the past, but now we have
>
> 	static int ptrace_setoptions(struct task_struct *child, unsigned long data)
> 	{
> 		unsigned flags;
>
> 		if (data & ~(unsigned long)PTRACE_O_MASK)
> 			return -EINVAL;
>
> 		/* Avoid intermediate state when all opts are cleared */
> 		flags = child->ptrace;
> 		flags &= ~(PTRACE_O_MASK << PT_OPT_FLAG_SHIFT);
> 		flags |= (data << PT_OPT_FLAG_SHIFT);
> 		child->ptrace = flags;
>
> 		return 0;
> 	}

Yup, I was looking at an older version of the code by mistake.  See patch to follow.  Thanks!

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/