linux-kernel - Re: [GIT PULL] perf changes for v3.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121213165904.GA18574@gmail.com>
Date:	Thu, 13 Dec 2012 17:59:04 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	David Ahern <dsahern@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] perf changes for v3.8


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> > I could write the patch to completely invert the 
> > exclude_guest logic -- make it include_guest. That breaks 
> > all existing perf binaries as well - just a different syntax 
> > that gets broken. That regression is acceptable?
> 
> It's not a regression since THAT CODE NEVER WORKED, for 
> chissake! The case of people actually profiling into virtual 
> machines crashes the running VMs, as you say. There's no way 
> in hell we can call it a regression to say "you now have to 
> use a flag if you profile a load with virtualization", since 
> there wasn't any working case to begin with.

Correct.

::include_guest looks like the more logical flag direction to
use in any case.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/