linux-kernel - Re: [PATCH] pwm: samsung: add missing s3c->pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121214065200.GB24094@avionic-0098.adnet.avionic-design.de>
Date:	Fri, 14 Dec 2012 07:52:01 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Joonyoung Shim <jy0922.shim@...sung.com>
Cc:	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kgene.kim@...sung.com, kyungmin.park@...sung.com
Subject: Re: [PATCH] pwm: samsung: add missing s3c->pwm_id

On Fri, Dec 14, 2012 at 01:20:09PM +0900, Joonyoung Shim wrote:
> The s3c->pwm_id is used to calculate offset of related register.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@...sung.com>
> ---
>  drivers/pwm/pwm-samsung.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index 023a3be..b415102 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -220,6 +220,8 @@ static int s3c_pwm_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	}
>  
> +	s3c->pwm_id = id;
> +
>  	/* calculate base of control bits in TCON */
>  	s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;

Can you please move the assignment to below the above line? That way s3c
initialization is more localized.

Thierry

Content of type "application/pgp-signature" skipped