linux-kernel - Re: [PATCH 1/1]linux-usb: optimize to match rules in USB storage for Huawei dongles.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Dec 2012 11:40:20 +0200
From:	Felipe Balbi <balbi@...com>
To:	fangxiaozhi 00110321 <fangxiaozhi@...wei.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<zihan@...wei.com>, <Lin.Lei@...wei.com>, <greg@...ah.com>,
	<neil.yi@...wei.com>, <wangyuhua@...wei.com>, <huqiao36@...wei.com>
Subject: Re: [PATCH 1/1]linux-usb: optimize to match rules in USB storage for
 Huawei dongles.

On Fri, Dec 14, 2012 at 10:25:25AM +0800, fangxiaozhi 00110321 wrote:
> From: fangxiaozhi <huananhu@...wei.com>
> 
> 1. Add a new macro define for USB storage match rule.
> 2. Optimize the match rules with new macro for Huawei USB storage devices, 
>    to avoid to load USB storage driver for the modem interface 
>    with Huawei devices.
> 3. Add to support new switch command for new Huawei USB dongles.

still doing too much in a single patch. Should be broken down. Most of
my comments weren't taken into account. Why bother sending a new
version ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)