linux-kernel - RE: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <910F9D9E13B84F4C8FA771DC9BDE99F326FC0242@szxeml546-mbs.china.huawei.com>
Date:	Fri, 14 Dec 2012 10:28:31 +0000
From:	"Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com>
To:	Oliver Neukum <oneukum@...e.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Xueguiying (Zihan)" <zihan.xue@...wei.com>,
	"Linlei (Lei Lin)" <lei.lin@...wei.com>,
	"greg@...ah.com" <greg@...ah.com>,
	"Yili (Neil)" <neil.yi@...wei.com>,
	"Wangyuhua (Roger, Credit)" <wangyuhua@...wei.com>,
	Huqiao <huqiao36@...wei.com>
Subject: RE: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage
 devices and support new switch command

Dear Oliver:

> -----Original Message-----
> From: Oliver Neukum [mailto:oneukum@...e.de]
> Sent: Friday, December 14, 2012 5:34 PM
> To: Alan Cox
> Cc: Fangxiaozhi (Franko); linux-usb@...r.kernel.org;
> linux-kernel@...r.kernel.org; Xueguiying (Zihan); Linlei (Lei Lin);
> greg@...ah.com; Yili (Neil); Wangyuhua (Roger, Credit); Huqiao
> Subject: Re: [PATCH 1/1]linux-usb: optimize to match the Huawei USB
> storage devices and support new switch command
> 
> On Friday 14 December 2012 09:31:41 Alan Cox wrote:
> > On Fri, 14 Dec 2012 03:01:24 +0000
> > "Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com> wrote:
> >
> > > Dear Alan:
> > >
> > > 	This prevents people getting access to the storage device if they want.
> > > 	----In our device, after its switching, it will keep the cdrom port
> together with other ports (such as modem port). So you can access the
> storage device too, after our switch.
> >
> > Ok so the behaviour is
> >
> > 	plug in device
> > 	"I am a CD-ROM"
> > 	command sent
> > 	"I am a CD-ROM, I am a modem, I am other things"
> >
> > with the newer devices ?
> 
> For such devices we should put the switching code into generic code, not a
> device driver so that we have a chance to do reset_resume() on those
> devices.
--------------Because in many embedded linux system, they don't include such switch tools themselves. 
			So I think it is better to put the switching code in device driver.
--------------By the way, because our device will response the switching command for once, 
			so I think you can do reset_resume() as you want.

> 	Regards
> 		Oliver

Best Regards,
Franko Fang