linux-kernel - Re: [PATCH] ata: uncomment ata_timing for XFER_PIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121214111351.GA7307@liondog.tnic>
Date:	Fri, 14 Dec 2012 12:13:51 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...hat.com>
Subject: Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote:
> This patch uncomments ata timings for XFER_PIO_SLOW,
> otherwise ata_timing_find_mode() returns NULL and kernel crashes in
> pacpi_set_dmamode() after null-pointer dereference.
> 
> The same problem was mentioned recently in debug patch v3.7-rc5-72-gcd705d5
> ("libata debugging: Warn when unable to find timing descriptor based on xfer_mode")
> 
> I'm not sure about this patch, because I have no idea what this XFER_PIO_SLOW

No, this is already fixed by:

http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commitdiff;h=5416912af75de9cba5d1c75b99a7888b0bbbd2fb

Btw, this patch will go to stable since I can't find it in 3.7, I'm
guessing Jeff will send it to Linus soonish since it is in his NEXT
branch.

Until that happens, you could test 3.7 by cherrypicking the patch above
ontop of it or by simply applying it by hand since it is only two lines.

Or, you could wait and test -rc1 when it comes out after the world ends :-).

> means and why this bug so rare (3 times during 4 days boot-reboot test) I caught
> this on completely ordinary PC with nvidia MCP61 chipset, sata hdd and ide dvd-rom.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> Signed-off-by: Borislav Petkov <bp@...en8.de>
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

Btw, just FYI, this is not how S-o-b chaining works. Take a look
at <Documentation/SubmittingPatches> for details on how it is done
correctly.

HTH.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/