linux-kernel - Re: [PATCH 12/12] edac: fix kernel panic on module unloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Dec 2012 12:50:48 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Konstantin Khlebnikov <khlebnikov@...nvz.org>,
	linux-kernel@...r.kernel.org, Denis Kirjanov <kirjanov@...il.com>
Subject: Re: [PATCH 12/12] edac: fix kernel panic on module unloading

On Fri, Dec 14, 2012 at 11:26:57AM +0000, Alan Cox wrote:
> On Fri, 14 Dec 2012 15:03:10 +0400
> Konstantin Khlebnikov <khlebnikov@...nvz.org> wrote:
> 
> > This patch fixes use-after-free and double-free bugs in edac_mc_sysfs_exit().
> > mci_pdev has single reference and put_device() calls mc_attr_release() which
> > calls kfree(), thus following device_del() works with already released memory.
> > An another kfree() in edac_mc_sysfs_exit() releses the same memory again. Great.
> 
> Patches for this were posted a while ago by Jean Delvare. See bugzilla
> 50491 as well for this.

Jean's patch is for i7core_edac but Konstantin's fixes the edac_core
which is another module. And AFAICT the correct order of destroying
devices in the driver core is

1. _del
2. _put

so I'll pick up Konstantin's patch with a tag for 3.7-stable unless
someone has objections?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/