lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1355493455-30665-3-git-send-email-daniel.lezcano@linaro.org> Date: Fri, 14 Dec 2012 14:57:35 +0100 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: rjw@...k.pl Cc: jwerner@...omium.org, francescolavra.fl@...il.com, linux-pm@...r.kernel.org, deepthi@...ux.vnet.ibm.com, g.trinabh@...il.com, linaro-dev@...ts.linaro.org, len.brown@...el.com, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, snanda@...omium.org Subject: [PATCH 2/2][V2] cpuidle - optimize the select function for the 'menu' governor As the power is backward sorted in the states array and we are looking for the state consuming the little power as possible, instead of looking from the beginning of the array, we look from the end. That should save us some iterations in the loop each time we select a state at idle time. Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org> --- drivers/cpuidle/governors/menu.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c index fe343a0..05b8998 100644 --- a/drivers/cpuidle/governors/menu.c +++ b/drivers/cpuidle/governors/menu.c @@ -367,24 +367,24 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) * Find the idle state with the lowest power while satisfying * our constraints. */ - for (i = CPUIDLE_DRIVER_STATE_START; i < drv->state_count; i++) { + for (i = drv->state_count - 1; i >= CPUIDLE_DRIVER_STATE_START; i--) { struct cpuidle_state *s = &drv->states[i]; struct cpuidle_state_usage *su = &dev->states_usage[i]; if (s->disabled || su->disable) continue; - if (s->target_residency > data->predicted_us) { - low_predicted = 1; - continue; - } if (s->exit_latency > latency_req) continue; + if (s->target_residency > data->predicted_us) + continue; if (s->exit_latency * multiplier > data->predicted_us) continue; + low_predicted = i - CPUIDLE_DRIVER_STATE_START; data->last_state_idx = i; data->exit_us = s->exit_latency; - } + break; + } /* not deepest C-state chosen for low predicted residency */ if (low_predicted) { -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists