linux-kernel - Re: power: Add simple poweroff-gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121214150841.GA15843@redhat.com>
Date:	Fri, 14 Dec 2012 10:08:41 -0500
From:	Dave Jones <davej@...hat.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jamie Lentin <jm@...tin.co.uk>,
	Simon Baatz <gmbnomis@...il.com>,
	Jason Cooper <jason@...edaemon.net>
Subject: Re: power: Add simple poweroff-gpio driver

On Fri, Dec 14, 2012 at 09:21:50AM +0100, Andrew Lunn wrote:
 
 > > Given this seems to be dependant on device-tree, shouldn't there be
 > > some 'depends on' in the kconfig to prevent this showing up on architectures
 > > that don't implement it ? 
 > > 
 > >  > +menuconfig POWER_RESET
 > >  > +	bool "Board level reset or power off"
 > >  > +	help
 > >  > +	  Provides a number of drivers which either reset a complete board
 > >  > +	  or shut it down, by manipulating the main power supply on the board.
 > >  > +
 > >  > +	  Say Y here to enable board reset and power off
 > >  > +
 > >  > +config POWER_RESET_GPIO
 > >  > +	bool "GPIO power-off driver"
 > >  > +	depends on OF_GPIO && POWER_RESET
 >
 > Don't these depends on here do what you want?
 
I think it needs to be on the menuconfig, rather than the child options.
I don't have OF_GPIO, but I still got asked for the former.

 
 > > If not, upon seeing this, I suspect many users will ask "how do I know if I need this?"
 > > given there's no mention of the sort of hardware this is useful on.
 > 
 > Its a generic driver. I know its useful on various Marvell kirkwood
 > and orion5x devices. I've also heard it useful on some Tegra boards.
 > 
 > Are you asking i list these boards?

No, but at least mentioning the architecture might have clued me in quicker that this
wasn't some now ACPI-ism when I saw it on x86.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/