linux-kernel - Re: [PATCH] mm: clean up soft_offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1355499456-3311-1-git-send-email-n-horiguchi@ah.jp.nec.com>
Date:	Fri, 14 Dec 2012 10:37:36 -0500
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Xishi Qiu <qiuxishi@...wei.com>
Cc:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Tony Luck <tony.luck@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Jiang Liu <jiang.liu@...wei.com>,
	Borislav Petkov <bp@...en8.de>,
	Simon Jeons <simon.jeons@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: clean up soft_offline_page()

Hi Xishi,

On Fri, Dec 14, 2012 at 11:06:56AM +0800, Xishi Qiu wrote:
> On 2012/12/14 7:01, Naoya Horiguchi wrote:
...
> > +	ret = get_any_page(page, pfn, flags);
> > +	if (ret < 0)
> > +		return ret;
> > +	if (ret) { /* for in-use pages */
> > +		if (PageHuge(page))
> > +			soft_offline_huge_page(page, flags);
> 
> ret = soft_offline_huge_page(page, flags);
> 
> > +		else
> > +			__soft_offline_page(page, flags);
> 
> ret = __soft_offline_page(page, flags); right?

Ah, you're right, Thanks!

Naoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/