linux-kernel - [PATCH 18/21] gpio: ab8500: Fix parameter uninitialized warning for ab8540

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1355501979-1157-19-git-send-email-lee.jones@linaro.org>
Date:	Fri, 14 Dec 2012 16:19:36 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	linus.walleij@...aro.org, Yang QU <yang.qu@...ricsson.com>,
	Lee Jones <lee.jones@...aro.org>
Subject: [PATCH 18/21] gpio: ab8500: Fix parameter uninitialized warning for ab8540

From: Yang QU <yang.qu@...ricsson.com>

Missing initial value in ab8540 gpio configuration function. So
initialize it and fix this warning.

Signed-off-by: Lee Jones <lee.jones@...aro.org>
Signed-off-by: Yang QU <yang.qu@...ricsson.com>
Reviewed-by: Rabin VINCENT <rabin.vincent@...ricsson.com>
---
 drivers/gpio/gpio-ab8500.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-ab8500.c b/drivers/gpio/gpio-ab8500.c
index b4f631a..833d4c2 100644
--- a/drivers/gpio/gpio-ab8500.c
+++ b/drivers/gpio/gpio-ab8500.c
@@ -673,6 +673,8 @@ int ab8540_gpio_config_vinsel(struct device *dev,
 		goto out;
 	}
 
+	pos = (gpio - AB8500_PIN_GPIO(51)) << 1;
+
 	ret = abx500_mask_and_set_register_interruptible(dev,
 			AB8500_MISC, AB8540_GPIO_VINSEL_REG,
 			AB8540_GPIO_VINSEL_MASK << pos, val << pos);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/