linux-kernel - Re: power: Add simple poweroff-gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121214200519.GA32268@redhat.com>
Date:	Fri, 14 Dec 2012 15:05:19 -0500
From:	Dave Jones <davej@...hat.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jamie Lentin <jm@...tin.co.uk>,
	Simon Baatz <gmbnomis@...il.com>,
	Jason Cooper <jason@...edaemon.net>
Subject: Re: power: Add simple poweroff-gpio driver

On Fri, Dec 14, 2012 at 08:53:40PM +0100, Andrew Lunn wrote:
 > > > I think it needs to be on the menuconfig, rather than the child options.
 > > > I don't have OF_GPIO, but I still got asked for the former.
 > > 
 > > The menuconfig enables a class of drivers (at least theoretically in the
 > > future, when more such drivers turn up), and there's no reason to
 > > believe that all of those drivers will depend on OF. So in my opinion,
 > > making POWER_RESET_GPIO depend on OF makes sense, but making POWER_RESET
 > > depend on it doesn't.
 > 
 > I have another driver coming soon which will not depend on OF_GPIO. It
 > does however depend on OF. Its for a class of boards which have a
 > microcontroller controlling the main power supply, and sending an
 > character over a UART port is used to turn the board power off.
 > 
 > There might also be some legacy drivers which could be moved here
 > which don't depend on OF at all.
 > 
 > So i would prefer to keep POWER_RESET generic.

Perhaps a CONFIG_ARCH_WANT_POWER_RESET option for arches that opt-in ?

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/