lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 16 Dec 2012 09:10:03 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Arvind R <arvino55@...il.com>
Cc:	linux-edac@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-next@...r.kernel.org
Subject: Re: [PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors

Hi Arvind,

On Sun, 16 Dec 2012 02:08:50 +0530 Arvind R <arvino55@...il.com> wrote:
>
> Subject: [PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors
> 
> splits or shortens extra long lines in source.

Don't do this, except for the one marked below, these add no value.  The
line length is a guide.

> -			snprintf(csrow->channels[chan]->dimm->label, EDAC_MC_LABEL_LEN, "DIMM %c%d",
> +			snprintf(csrow->channels[chan]->dimm->label,
> +				 EDAC_MC_LABEL_LEN, "DIMM %c%d",

Only keep this one.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists