linux-kernel - Re: [PATCH 1/1] cpuidle: coupled: fix ready counter decrement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMbhsRQXAwObH0TL9Kx9pCscQ3r19_KyV9MCMTQ_qYfrxP5XTw@mail.gmail.com>
Date:	Fri, 14 Dec 2012 17:53:28 -0800
From:	Colin Cross <ccross@...roid.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Sivaram Nair <sivaramn@...dia.com>, santosh.shilimkar@...com,
	khilman@...com, daniel.lezcano@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] cpuidle: coupled: fix ready counter decrement

On Fri, Dec 14, 2012 at 3:37 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Friday, December 14, 2012 10:42:08 AM Sivaram Nair wrote:
>> The ready_waiting_counts atomic variable is compared against the wrong
>> online cpu count. The latter is computed incorrectly using logical-OR
>> instead of bit-OR. This patch fixes that.
>
> I'm queuing this up for submission as v3.8 material.
>
> I suppose it should be marked for -stable too?
>
> Rafael

Acked-by: Colin Cross <ccross@...roid.com>

Looks suitable for stable.

>> Signed-off-by: Sivaram Nair <sivaramn@...dia.com>
>> ---
>>  drivers/cpuidle/coupled.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
>> index 3265844..2a297f8 100644
>> --- a/drivers/cpuidle/coupled.c
>> +++ b/drivers/cpuidle/coupled.c
>> @@ -209,7 +209,7 @@ inline int cpuidle_coupled_set_not_ready(struct cpuidle_coupled *coupled)
>>       int all;
>>       int ret;
>>
>> -     all = coupled->online_count || (coupled->online_count << WAITING_BITS);
>> +     all = coupled->online_count | (coupled->online_count << WAITING_BITS);
>>       ret = atomic_add_unless(&coupled->ready_waiting_counts,
>>               -MAX_WAITING_CPUS, all);
>>
>>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/