linux-kernel - Re: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWFRMpxQTTbS+p21EjBvmetup75zD6ipc3COZg7=KyNig@mail.gmail.com>
Date:	Sun, 16 Dec 2012 09:59:01 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Fenghua Yu <fenghua.yu@...el.com>
Cc:	H Peter Anvin <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Asit K Mallick <asit.k.mallick@...el.com>,
	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

On Sun, Dec 16, 2012 at 2:43 AM, Fenghua Yu <fenghua.yu@...el.com> wrote:
> From: Fenghua Yu <fenghua.yu@...el.com>
>
> This updates ucode in 64-bit mode. Paging and virtual address are working now.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> ---
>  arch/x86/kernel/head64.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> index 037df57..a512f56 100644
> --- a/arch/x86/kernel/head64.c
> +++ b/arch/x86/kernel/head64.c
> @@ -25,6 +25,7 @@
>  #include <asm/kdebug.h>
>  #include <asm/e820.h>
>  #include <asm/bios_ebda.h>
> +#include <asm/microcode.h>
>
>  static void __init zap_identity_mappings(void)
>  {
> @@ -73,6 +74,11 @@ void __init x86_64_start_kernel(char * real_mode_data)
>         /* clear bss before set_intr_gate with early_idt_handler */
>         clear_bss();
>
> +       /*
> +        * Load microcode early on BSP.
> +        */
> +       load_ucode_bsp(real_mode_data);
> +
>         /* Make NULL pointers segfault */
>         zap_identity_mappings();
>

So this patchset is after #PF handler set early page table version?

then load_ucode_bsp() should be after

   load_idt((const struct desc_ptr *)&idt_descr);

otherwise it will not work.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/