linux-kernel - Re: [PATCH 3.7.0 3/9] i82975x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Dec 2012 18:08:39 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Arvind R <arvino55@...il.com>, linux-edac@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, linux-next@...r.kernel.org
Subject: Re: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code

On Mon, Dec 17, 2012 at 12:45:11PM -0200, Mauro Carvalho Chehab wrote:
> Em Sun, 16 Dec 2012 02:10:39 +0530
> Arvind R <arvino55@...il.com> escreveu:
> 
> > Subject: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code
> > 
> > modify debug levels to sane levels. Also move random debug code
> > into CONFIG_EDAC_DEBUG sections.
> > Signed-off-by: Arvind R. <arvino55@...il.com>
> > ---
> >  i82975x_edac.c |  171 +++++++++++++++++++++++-------------------
> >  1 file changed, 97 insertions(+), 74 deletions(-)
> > 
> > --- a/drivers/edac/i82975x_edac.c	2012-12-15 20:18:24 +0530
> > +++ b/drivers/edac/i82975x_edac.c	2012-12-15 20:17:58 +0530
> ...
> > @@ -551,11 +583,11 @@ static int i82975x_probe1(struct pci_dev
> >  	layers[1].is_virt_csrow = false;
> >  	mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt));
> >  	if (!mci) {
> > +		edac_dbg(0, "MC%d failed mc_alloc\n", dev_idx);
> >  		rc = -ENOMEM;
> >  		goto fail1;
> 
> Please remove the two last lines. There's no reason why it a driver 
> should bail out just because debug is enabled.

Huh? He's adding a debug line to say that edac_mc_alloc() failed.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/