| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121217191041.GD7235@redhat.com> Date: Mon, 17 Dec 2012 14:10:41 -0500 From: Vivek Goyal <vgoyal@...hat.com> To: Tejun Heo <tj@...nel.org> Cc: lizefan@...wei.com, axboe@...nel.dk, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org, ctalbott@...gle.com, rni@...gle.com Subject: Re: [PATCH 01/12] blkcg: fix minor bug in blkg_alloc() On Fri, Dec 14, 2012 at 02:41:14PM -0800, Tejun Heo wrote: > blkg_alloc() was mistakenly checking blkcg_policy_enabled() twice. > The latter test should have been on whether pol->pd_init_fn() exists. > This doesn't cause actual problems because both blkcg policies > implement pol->pd_init_fn(). Fix it. > > Signed-off-by: Tejun Heo <tj@...nel.org> Acked-by: Vivek Goyal <vgoyal@...hat.com> Vivek > --- > block/blk-cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > index 3f6d39d..feda49f 100644 > --- a/block/blk-cgroup.c > +++ b/block/blk-cgroup.c > @@ -114,7 +114,7 @@ static struct blkcg_gq *blkg_alloc(struct blkcg *blkcg, struct request_queue *q, > pd->blkg = blkg; > > /* invoke per-policy init */ > - if (blkcg_policy_enabled(blkg->q, pol)) > + if (pol->pd_init_fn) > pol->pd_init_fn(blkg); > } > > -- > 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists