linux-kernel - Re: [PATCH 1/2] menuconfig: Add Save/Load buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Dec 2012 21:37:26 +0100
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	linux-kbuild@...r.kernel.org
Cc:	Wang YanQing <udknight@...il.com>, mmarek@...e.cz,
	linux-kernel@...r.kernel.org, rdunlap@...otime.net, bp@...en8.de,
	sakiwit@...il.com, lacombar@...il.com,
	lucas.demarchi@...fusion.mobi, dave@....org,
	paul.gortmaker@...driver.com, crquan@...il.com, bpoirier@...e.de
Subject: Re: [PATCH 1/2] menuconfig: Add Save/Load buttons

Wang, All,

On Monday 17 December 2012 Wang YanQing wrote:
> If menuconfig have Save/Load button like alternative
> .config editors, xconfig, nconfig, etc.We will have
> a obvious benefit when use menuconfig just like
> when we use others, we can Save/Load our .config quickly
> and conveniently.
> 
> This patch add the Save/Load button for menuconfig.
> 
> [remove trailing space while at it for below line:
> "*)  Formerly when I used Page Down and Page Up, the cursor would be set"
> ]
> 
> Signed-off-by: Wang YanQing <udknight@...il.com>
[--SNIP--]
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 53975cf..c074f8a 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
[--SNIP--]
> @@ -702,6 +709,17 @@ static void show_helptext(const char *title, const char *text)
>  	show_textbox(title, text, 0, 0);
>  }
>  
> +static void conf_message_callback(const char *fmt, va_list ap)
> +{
> +	char buf[1024];

char buf[PATH_MAX+1];

[--SNIP--]
> @@ -948,4 +968,3 @@ int main(int ac, char **av)
>  
>  	return res;
>  }
> -

Spurious empty-line removal. Don't.

Otherwise, I've tested it, and it works great! :-)
Care to repost with the changes above (wait a bit in case of more review
by others), and you'll get my tst-by and rev'ed-by tags.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/